[PATCH v2][BZ 16852] Do not clobber recvmmsg argument.

Ondřej Bílka neleai@seznam.cz
Wed Apr 30 09:07:00 GMT 2014


On Wed, Apr 30, 2014 at 10:28:53AM +0200, Michael Kerrisk (man-pages) wrote:
> On 04/28/2014 07:01 PM, David Miller wrote:
> > From: Ondřej Bílka <neleai@seznam.cz>
> > Date: Mon, 28 Apr 2014 18:04:20 +0200
> > 
> >> 	* sysdeps/unix/sysv/linux/recvmmsg.c (recvmmsg): Do not clobber
> >> 	timeout argument.
> > 
> > It is extremely unfortunate if we've defined this argument as const,
> > now you are making it so that the user has no mechanism to get the
> > updated timeval other than to define their own syscall stubs.
> > 
> > This is doubly unfortunately since there is absolutely no reason for
> > us to have defined the interface different from what the kernel
> > actually provides.
> 
> Agreed. Surely, the right fix here is simply to remove the "const" 
> qualifier from the glibc API?
> 
Now I am also for removing const. Initially I looked to documentation
and this was undocumented feature so I was not sure about it. Could we
also document this in manpages?



More information about the Libc-alpha mailing list