[PATCH] Do not run timezone tests in parallel.

Stefan Liebler stli@linux.vnet.ibm.com
Tue Apr 15 14:48:00 GMT 2014


Hi,

running the testsuite with PARALLELMFLAGS="-j2"
leads to an UNRESOLVED test:
timezone/testdata/UTC.
-> The timezone/testdata/UTC.test-result file does not exist
and timezone/testdata/Etc/UTC.test-result exists.
According to the output of make, Etc/UTC is called directly before UTC
and both targets collide in parallel execution.
Thus we should not execute the timezone-tests in parallel.

Ok to commit?

Bye

---
2014-04-15  Stefan Liebler  <stli@linux.vnet.ibm.com>

	* timezone/Makefile: Do nothing in parallel.
---
-------------- next part --------------
diff --git a/timezone/Makefile b/timezone/Makefile
index 998cd14..2f6e80e 100644
--- a/timezone/Makefile
+++ b/timezone/Makefile
@@ -85,6 +85,9 @@ GCONV_PATH=${common-objpfx}iconvdata LANGUAGE=C LC_ALL=C \
 $(evaluate-test)
 endef
 
+
+.NOTPARALLEL:
+
 $(objpfx)test-tz.out: $(addprefix $(testdata)/, America/New_York Etc/UTC UTC)
 $(objpfx)tst-timezone.out: $(addprefix $(testdata)/, \
 				       Europe/Berlin Universal \
@@ -102,7 +105,6 @@ $(testdata)/America/New_York: northamerica $(zic-deps)
 	$(build-testdata)
 $(testdata)/Etc/UTC: etcetera $(zic-deps)
 	$(build-testdata)
-# Use a pattern rule to indicate the command produces both targets at once.
 # Two separate targets built separately can collide if in parallel.
 %/UTC %/Universal: simplebackw $(zic-deps) %/Etc/UTC
 	$(build-testdata)


More information about the Libc-alpha mailing list