[patch] Fix bug 15915, erroneous make rule for linkobj/libc.so.

Brooks Moses bmoses@google.com
Tue Sep 17 18:38:00 GMT 2013


Ping?

Roland, as per Ryan's request, I'm waiting on an Ack from you before committing.

On Mon, Sep 9, 2013 at 1:38 PM, Brooks Moses <bmoses@google.com> wrote:
> Steve,
>
> On Mon, Sep 9, 2013 at 1:03 PM, Steve Ellcey <sellcey@mips.com> wrote:
>> I think there are still some tab/space problems with this patch.  It
>> applied cleanly but when I built I got:
>
> Crud; I'm sorry.  I guess this is what I get from cut-and-pasting
> things from a diff file (trying to get a revised patch out from my
> laptop this weekend so you wouldn't have to wait) rather than waiting
> until I could update my tree and test things properly.
>
> The attached patch is now properly tested (on a native build): It goes
> through a "configure --prefix=...; make -j24" cycle successfully, and
> the installed trees with and without the patch differ only in lib/*.a
> files, and those are exactly the same sizes implying that the
> differences are just timestamps.
>
> Roland, is this one ok to commit?
>
> - Brooks



More information about the Libc-alpha mailing list