[PATCH v2][BZ #832][BZ #3266] Make ldd try_trace more robust and portable

Mike Frysinger vapier@gentoo.org
Tue Sep 10 15:30:00 GMT 2013


On Saturday 07 September 2013 11:45:45 Patrick "P. J." McDermott wrote:
> This is a second version of my previous ldd try_trace patch [1], with
> feedback from Dmitry V. Levin [2][3].
> 
> [1]: http://sourceware.org/ml/libc-alpha/2012-11/msg00663.html
> [2]: http://sourceware.org/ml/libc-alpha/2012-11/msg00736.html
> [3]: http://sourceware.org/ml/libc-alpha/2013-06/msg01155.html

the commit message itself needs explanation.  only referring to previous 
mailing list entries is not sufficient.

> -# The following use of cat is needed to make ldd work in SELinux
> -# environments where the executed program might not have permissions
> -# to write to the console/tty.  But only bash 3.x supports the pipefail
> -# option, and we don't bother to handle the case for older bash versions.
> -if set -o pipefail 2> /dev/null; then

this seems like a simpler fix:
	if (set -o pipefail) 2>/dev/null; then

that works with dash and bash-2.05
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://sourceware.org/pipermail/libc-alpha/attachments/20130910/7e72f592/attachment.sig>


More information about the Libc-alpha mailing list