[PATCH] Add AARCH64 relocation constants to elf/elf.h
Carlos O'Donell
carlos@redhat.com
Tue Sep 3 20:11:00 GMT 2013
On 09/02/2013 05:13 AM, Petr Machata wrote:
> "Carlos O'Donell" <carlos@redhat.com> writes:
>
>> Your patch also does some whitespace changes that should not be in the same
>> patch as one that adds or renames new constants.
>
> I thought it was a regular practice, to fix coding style of code that
> you touch. But I can drop the whitespace adjustments if that's the
> preference.
I never find it appropriate to mix whitespace and code changes unless you're
rewriting the function.
For a change like this which might get backported by distributions it should
be as minimal as possible.
Cheers,
Carlos.
More information about the Libc-alpha
mailing list