[PATCH][BZ #16071] Fix file reads for large AF_INET requests from hosts file

Andreas Schwab schwab@suse.de
Mon Oct 28 11:31:00 GMT 2013


Siddhesh Poyarekar <siddhesh@redhat.com> writes:

> @@ -202,8 +242,8 @@ internal_getent (struct STRUCTURE *result,
>      {
>        /* Terminate the line so that we can test for overflow.  */
>        ((unsigned char *) data->linebuffer)[linebuflen - 1] = '\xff';
> +      p = get_contents (data->linebuffer, linebuflen, stream);

The overflow check should be moved into the wrapper function, which
already does something similar.  It can return a tristate
ok/eof/overflow instead of the buffer pointer, which the caller already
knows.

Andreas.

-- 
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."



More information about the Libc-alpha mailing list