[PATCHv1.1 1/2] Consolidate condition check for return value in mp asin and acos

[Siddhesh Poyarekar]

On Mon, Oct 28, 2013 at 09:02:38AM +0100, Andreas Jaeger wrote:
> This part should give:
> a.d[0] > 0 && !(res < res1)
> 
> > -  else
> > -    return (res > res1) ? res : res1;
> 
> And this condition:
> !(a.d[0] > 0) && !(res > res1)
> 
> > +  if ((a.d[0] > 0 && res > res1) || (a.d[0] <= 0 && res < res1))
> 
> In that case it should be res >= res1 for the first paren and "res <=
> res1" for the second.
> 

Thanks, here's the updated patch.  Looks OK now?

Siddhesh

	* sysdeps/ieee754/dbl-64/sincos32.c (__sin32): Consolidate
	conditional check for return value.
	(__cos32): Likewise.


diff --git a/sysdeps/ieee754/dbl-64/sincos32.c b/sysdeps/ieee754/dbl-64/sincos32.c
index f253b8c..49aa148 100644
--- a/sysdeps/ieee754/dbl-64/sincos32.c
+++ b/sysdeps/ieee754/dbl-64/sincos32.c
@@ -147,10 +147,9 @@ __sin32 (double x, double res, double res1)
   __dbl_mp (x, &c, p);		/* c = x  */
   __sub (&b, &c, &a, p);
   /* if a > 0 return min (res, res1), otherwise return max (res, res1).  */
-  if (a.d[0] > 0)
-    return (res < res1) ? res : res1;
-  else
-    return (res > res1) ? res : res1;
+  if ((a.d[0] > 0 && res >= res1) || (a.d[0] <= 0 && res <= res1))
+    res = res1;
+  return res;
 }
 
 /* Receive double x and two double results of cos(x) and return result which is
@@ -181,10 +180,9 @@ __cos32 (double x, double res, double res1)
   __dbl_mp (x, &c, p);		/* c = x                  */
   __sub (&b, &c, &a, p);
   /* if a > 0 return max (res, res1), otherwise return min (res, res1).  */
-  if (a.d[0] > 0)
-    return (res > res1) ? res : res1;
-  else
-    return (res < res1) ? res : res1;
+  if ((a.d[0] > 0 && res <= res1) || (a.d[0] <= 0 && res >= res1))
+    res = res1;
+  return res;
 }
 
 /* Compute sin() of double-length number (X + DX) as Multi Precision number and