[PATCH 2.0][BZ #15670] Replace alloca in __tzfile_read by malloc.
Mike Frysinger
vapier@gentoo.org
Thu Oct 17 02:43:00 GMT 2013
On Wednesday 16 October 2013 12:40:40 Ondřej Bílka wrote:
> @@ -173,6 +164,7 @@ __tzfile_read (const char *file, size_t extra, char
> **extrap) {
> /* Nothing to do. */
> __use_tzfile = 1;
> + free (new);
> return;
> }
i wonder if this would benefit from a "goto done" and then adding "done:" at
the end ...
> @@ -528,11 +520,13 @@ __tzfile_read (const char *file, size_t extra, char
> **extrap) __timezone = -rule_stdoff;
>
> __use_tzfile = 1;
> + free (new);
> return;
this would get a new "done:" label
either way, LGTM
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://sourceware.org/pipermail/libc-alpha/attachments/20131017/c1642dee/attachment.sig>
More information about the Libc-alpha
mailing list