[PATCH][BZ #13724] Do not segfault in pthread_setname_np (x, NULL)
Carlos O'Donell
carlos@redhat.com
Tue Oct 8 16:01:00 GMT 2013
On 10/07/2013 10:19 AM, Rich Felker wrote:
> If you're going to check for NULL pointer arguments where you have
> not entered into a contract to accept and interpret them, do it
> with an assert, not a conditional error return. This way the bugs
> in the caller will be immediately detected and can be fixed, and
> it makes it easy to disable the overhead in production builds. I
> question the value of the assert except as documentation however;
> a segfault from dereferencing the NULL pointer is just as
> effective for debugging.
Should we have an assert there then to document the contract and provide
a more meaningful error message like a backtrace?
Cheers,
Carlos.
More information about the Libc-alpha
mailing list