[ping2][PATCH][BZ #16077] Get canonical name in getaddrinfo from hosts file for AF_INET
Siddhesh Poyarekar
siddhesh@redhat.com
Mon Nov 25 19:10:00 GMT 2013
On Mon, Nov 25, 2013 at 05:55:36AM -0500, Pavel Simerda wrote:
> Looks good. But I think it would to get a little bit nearer to what I wrote above and...
>
> * Rename gethostbyname2 to gethostbyname3 and accept a NULL canonp.
> * Create a gethostbyname2 that would just call gethostbyname3(..., NULL)
>
> Does that sound reasonable?
>
I agree with your idea, but that is a separate cleanup IMO. Right now
it would be better to have a uniform mess so that someone doing the
mechanical work of cleaning things up does not have to deal with
different implementations in different modules.
Thanks for the review though. I believe I need at least one more
review from a maintainer before I can commit this.
Siddhesh
More information about the Libc-alpha
mailing list