[PATCH v2][BZ #10253] Fix breaking of RPATH when $ORIGIN contains colons.
Ondřej Bílka
neleai@seznam.cz
Mon Nov 18 23:57:00 GMT 2013
On Mon, Nov 18, 2013 at 05:05:10PM -0500, Carlos O'Donell wrote:
> On 11/18/2013 04:45 PM, Paul Pluzhnikov wrote:
> > On Mon, Nov 18, 2013 at 10:23 AM, Carlos O'Donell <carlos@redhat.com> wrote:
> >
> >> This looks good to me.
> >
> > Build break on Linux/x86_64:
> >
> > dl-load.c:495:7: error: too few arguments to function
> > âexpand_dynamic_string_tokenâ
> > to_free = cp = expand_dynamic_string_token (l, cp);
> > ^
> > dl-load.c:414:1: note: declared here
> > expand_dynamic_string_token (struct link_map *l, const char *s, int is_path)
> > ^
>
> Paul,
>
> Thanks for that. I also see the same build breakage. If you have commit
> rights please feel free to immediately revert the patch since that's our
> policy for glibc.
>
> https://sourceware.org/glibc/wiki/Consensus -> Bad Changes.
>
I ran make check to be sure, to check that there are nothing else wrong,
ok to put fixed version back?
More information about the Libc-alpha
mailing list