[PATCH] HPPA/IA64 : Don't use broken DL_AUTO_FUNCTION_ADDRESS()

[Carlos O'Donell]

On 11/07/2013 08:53 AM, Guy Martin wrote:
> On 2013-11-07 09:27, Andreas Schwab wrote:
>>
>> DL_CALL_DT_FINI whould be a more logical name.
>>
>>> +  /* Set bit 30 to indicate to $$dyncall that this is a PLABEL. */    \
>>> +  addr = (ElfW(Addr))((unsigned int)fptr | 2);                \
>>
>> That can't be correct.
> 
> 
> Thanks for reviewing, I've attached an update.
> Tested on amd64 and hppa.
> 
> Regards,
>   Guy
> 
> glibc-fix-DL_AUTO_FUNCTION_ADDRESS-v3.patch
> 
> 
> Main ChangeLog :
> 
> 2013-11-07  Guy Martin  <gmsoft@tuxicoman.be>
> 
> 	* sysdeps/generic/ldsodefs.h: Replace DL_DT_INIT_ADDRESS() and
> 	DL_DT_FINI_ADDRESS() macro with DL_CALL_DT_INIT() and
> 	DL_CALL_DT_FINI() that call the functions directly.
> 	* elf/dl-init.c: Use the new DL_CALL_DT_INIT() macro.
> 	* elf/dl-close.c: Use the new DL_CALL_DT_FINI() macro.
> 	* elf/dl-fini.c: Likewise.
> 
> Ports ChangeLog :
> 	
> 2013-11-07  Guy Martin  <gmsoft@tuxicoman.be>
> 	
> 	* sysdeps/hppa/dl-lookupcfg.h: Remove obsolete
> 	DL_DT_INIT_ADDRESS() and DL_DT_FINI_ADDRESS() macro and implement
> 	DL_CALL_DT_INIT() as well as DL_CALL_DT_FINI().
> 	Define DL_DT_FUNCTION_ADDRESS().
> 	* sysdeps/ia64/dl-lookupcfg.h: Likewise.
> 	* sysdeps/hppa/dl-machine.h: Update ELF_MACHINE_START_ADDRESS()
> 	to use DL_DT_FUNCTION_ADDRESS().
> 	* sysdeps/ia64/dl-machine.h: Likewise.

This looks good to me and makes everything cleaner.

Can you check this in yourself or do you need someone to check it in for you?

Cheers,
Carlos.