[PATCH] Ensure DSO_FILENAME does not dereference NULL.
Marcus Shawcroft
marcus.shawcroft@linaro.org
Tue Nov 12 22:28:00 GMT 2013
On 12 November 2013 18:27, <pinskia@gmail.com> wrote:
>> One effect of this patch is to replace unreachable paths with a call to abort().
>
> Hmm, it calls __builtin_trap shouldn't GCC back end for both arm and aarch64 support that directly instead?
Yep, I agree both gcc backends should get support for
__builtin_trap(), (Ill make sure a patch appears shortly), but I think
that this and the related patch I posted earlier for glibc both still
stand.
In the case of this patch, given:
#define DSO_FILENAME(name) ((name)[0] ? (name) : (rtld_progname ?:
"<main program>"))
...
const char *reference_name = undef_map ? undef_map->l_name : NULL;
_dl_signal_cerror (0, DSO_FILENAME (reference_name), .... )
the attempt to give NULL to DSO_FILENAME() when undef_map == NULL is wrong.
Cheers
/Marcus
More information about the Libc-alpha
mailing list