[PATCH 1/2] malloc/malloc.c: Validate SIZE passed to aligned_alloc.

Joseph S. Myers joseph@codesourcery.com
Fri Nov 8 13:44:00 GMT 2013


On Fri, 8 Nov 2013, Will Newton wrote:

> > I'm against unnecessary and (mildly) expensive validation of a
> > condition that the implementation is not required to validate and for
> > which the check has no purpose except for intentionally breaking
> > non-portable code.
> 
> My initial interest in this came from documenting the aligned_alloc
> interface. So should we document this non-standard behaviour?

I say document only what the standard requires, but don't add extra 
validation - the general practice in glibc is not to make glibc slower or 
bigger for valid code by checking for conditions that can only arise when 
the user's call to a glibc function means undefined behavior (this is much 
the same as not checking for NULL arguments when a function's interface 
doesn't allow them, for example).

-- 
Joseph S. Myers
joseph@codesourcery.com



More information about the Libc-alpha mailing list