[PATCH v2] [BZ #10283] localedef: align fixed maps to SHMLBA

[Carlos O'Donell]

On 05/28/2013 04:07 PM, David Miller wrote:
> From: Roland McGrath <roland@hack.frob.com>
> Date: Tue, 28 May 2013 12:40:42 -0700 (PDT)
> 
>> The fact that SHMLBA is the right size for this is a Linuxism.  It should
>> not be used directly in generic libc code.  Instead, add a private sysdeps/
>> header to define a macro or function that yields this larger-than-page size
>> and explains what uses need to use this size.  If it's then the most
>> sensible thing for a machine-independent linux/ implementation of this
>> header to use SHMLBA, then fine.
> 
> Solaris has this restriction, for the same exact reason, too, it's not
> a Linux'ism.
> 
> Anyone OS which properly supports avoidance illegal cache aliases (and
> thus, memory corruption) will need to impose this restriction.
> 

Then it's a Solaris-ism, and if we had a Solaris port we'd be refactoring
this into the Linux and Solaris OS sysdep directories.

I know it's a little pedantic, but it's not a generic issue, and thus I
agree that it should be a part of the OS/hardware support code.

Unless you're arguing that macro-izing such OS/hardware dependent code
makes the resulting implementation less maintainable?

Cheers,
Carlos.