[PATCH v2][BZ #13152] fmemopen does not honor append mode.

Ondřej Bílka neleai@seznam.cz
Mon May 20 08:44:00 GMT 2013


On Thu, May 16, 2013 at 05:29:37PM -0700, Roland McGrath wrote:
> > -	tst-mmap2-eofsync tst-mmap-offend test-fopen-bz12685 bug-fopena+ bug-wfflush \
> > +	tst-mmap2-eofsync tst-mmap-offend test-fopen-bz12685 test-fmemopen-bz13152 bug-fopena+ bug-wfflush \
> 
> This line is too long (it already was, but fix it now).
> 
> > +      if (mode[0] == 'a')
> > +	{
> > +	  len -= c->maxpos;
> > +	  c->buffer += c->maxpos;
> > +	  c->maxpos = 0;
> > +	}
> 
> How can this possibly be right for "a+" mode or ftell?
> 
ok, need will post new version.



More information about the Libc-alpha mailing list