[PATCH 2/9] Add the low level infrastructure for pthreads lock elision with TSX

Carlos O'Donell carlos@redhat.com
Tue May 14 07:31:00 GMT 2013


On 05/14/2013 03:14 AM, Andreas Jaeger wrote:
> On 05/14/2013 12:30 AM, Andi Kleen wrote:
>>>> +        {
>>>> +          char *end;
>>>> +          int val;
>>>> +
>>>> +          if (s[nlen] != '=')
>>>> +        {
>>>> +            complain (PAIR ("pthreads: invalid GLIBC_MUTEX syntax: missing =\n"));
>>>
>>> These warnings are not localized - can/want we have them localized?
>>
>> I doubt the locale facility is up at this point.
>> pthreads initialization is very early and I had a lot of problems
>> with such dependencies.
> 
> That's what I feared - if that's the case, ignore my comments ;)

I disbelieve this.

This code is run from elision_init which is in .init_array or .preinit_array.

You should have all the functionality of the C library by that point?

Don't C++ static constructors are run from these?

What problems did you have localizing this?

Cheers,
Carlos.



More information about the Libc-alpha mailing list