PowerPC's math_ldbl.h

[Ryan S. Arnold]

On Thu, Mar 7, 2013 at 1:26 PM, Andreas Jaeger <aj@suse.com> wrote:
> On 02/22/2013 08:11 PM, Adhemerval Zanella wrote:
>>
>> On 02/22/2013 12:46 PM, Joseph S. Myers wrote:
>>>
>>> On Fri, 22 Feb 2013, Adhemerval Zanella wrote:
>>>
>>>>         * sysdeps/unix/sysv/linux/powerpc/Implies: Add powerpc/fpu prior
>>>> to
>>>>         ieee754/ldbl-128ibm so sysdeps/powerpc/fpu/math_ldbl.h will be
>>>> included
>>>>         first.
>>>
>>> That's wrong - powerpc --without-fp will be using
>>> sysdeps/unix/sysv/linux/powerpc but can't use sysdeps/powerpc/fpu.
>>>
>> Indeed I didn't take nofpu in consideration. This patch now removes the
>> sysdeps/unix/sysv/linux/powerpc/Implies and adds the ldbl after ldbl-opt
>> on sysdeps/powerpc/Implies. This makes sysdeps/powerpc/fpu not appear with
>> nofpu build while add making it show before sysdeps/ieee754/ldbl-128ibm
>> so the PPC specific optimization is still used.
>>
>>
>> 2013-02-22  Adhemerval Zanella  <azanella@linux.vnet.ibm.com>
>>
>>         * sysdeps/ieee754/ldbl-128ibm/math_ldbl.h (ldbl_pack): Renamed to
>>         default_ldbl_pack and using as default implementation.
>
>
> Just a few nits on the changes entry:
>
> We normally active instead of passive, so "Rename to..."
>
>
>>         (ldbl_unpack): Renamed to default_ldbl_unpack and using as default
>>         implementation.
>>         * sysdeps/powerpc/fpu/math_ldbl.h (ldbl_extract_mantissa): removed
>>         redundant definition.
>
>
> capitalize the entry "Remove..."
>
>>         (ldbl_insert_mantissa): Likewise.
>>         (ldbl_canonicalize): Likewise.
>>         (ldbl_nearbyint): Likewise.
>>         (ldbl_pack): Renamed to ldbl_pack_ppc.
>>         (ldbl_unpack): Renamed to ldbl_unpack_ppc.
>>         * sysdeps/unix/sysv/linux/powerpc/Implies: Remove file.
>>         * sysdeps/powerpc/Implies: Add ieee754/ldbl-opt after
>> ieee754/ldbl-128ibm.
>
>
> The change itself looks fine. Ryan, could you give your blessing, please?

This is fine with me as soon as Andreas's suggested changes are made.

Ryan