Ping: [PATCH v4] faster strlen on x64
Andreas Jaeger
aj@suse.com
Wed Mar 6 21:26:00 GMT 2013
On 03/06/2013 10:00 PM, OndÅej BÃlka wrote:
> On Tue, Mar 05, 2013 at 06:39:15PM +0100, OndÅej BÃlka wrote:
>>
>> I uploaded results to my page.
>> If nobody has objection I will commit it tomorrow.
> Commited.
Ondrej, I feel ashamed that nobody had time to review your patches in time.
Still, our rules ask for review by somebody else and thus I'm surprised
by your commit. Silent approval ("if nobody objects") without any kind
of review and approval is not the way to go.
Please revert the patch and let's give it a proper review with explicit
aprovals before you commit!
I'll do a first review now.
Next time if nobody reviews your submission, please ask gently again and
again...
Andreas
--
Andreas Jaeger aj@{suse.com,opensuse.org} Twitter/Identica: jaegerandi
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn,Jennifer Guild,Felix Imendörffer,HRB16746 (AG Nürnberg)
GPG fingerprint = 93A3 365E CE47 B889 DF7F FED1 389A 563C C272 A126
More information about the Libc-alpha
mailing list