Fwd: [PATCH] tdestroy() should allow passing 'NULL' for 'freefct' callback

Carlos O'Donell carlos@redhat.com
Wed Jun 26 12:36:00 GMT 2013


On 06/25/2013 05:32 PM, Roland McGrath wrote:
> This is a user-visible change, so needs a BZ.  Probably this should use a
> new symbol version.  The compat routine need not behave any differently.
> But when someone builds a new program that might rely on the new behavior,
> they should get a symbol version dependency that ensures that attempting to
> run that program against an older library will give a coherent
> binary-compatibility error rather than just crashing in tdestroy.

Roland,

Thanks for the review.

It has a user-visible BZ. It's BZ #15009, as written into the ChangeLog?

Versioning is an interesting point I hadn't considered. In the past I'd 
say we haven't always done this kind of bumping of the symbol version 
to ensure considerate error messages. Though I agree with you, bumping 
the symbol version is the right thing to do here.

I should really keep my eye out for more of these kinds of issues. It's
my fault that I missed this.

Ondrej,

Could you help with adding the appropriate symbol versioning to the patch?

Cheers,
Carlos.
 



More information about the Libc-alpha mailing list