Avoid spurious failures from <fenv.h> fallback functions
Joseph S. Myers
joseph@codesourcery.com
Fri Jun 21 17:07:00 GMT 2013
On Fri, 21 Jun 2013, Kaz Kojima wrote:
> Thomas Schwinge <thomas@codesourcery.com> wrote:
> > On Fri, 21 Jun 2013 08:46:19 +0900, Kaz Kojima <kkojima@rr.iij4u.or.jp> wrote:
> >> "Joseph S. Myers" <joseph@codesourcery.com> wrote:
> >>> Kaz, Thomas, note that there is no SH version of fgetexcptflg.c. This
> >>> looks like an oversight, given that all the other <fenv.h> functions
> >>> have SH implementations. Neither old nor new stub version would
> >>> really be correct for SH; there should be a real implementation.
> >>> Filed as bug 15655.
> >>
> >> It's really an oversight. I'd like to commit the attached patch
> >> if it's OK to Thomas.
> >
> >> 2013-06-21 Kaz Kojima <kkojima@rr.iij4u.or.jp>
> >>
> > [BZ #15655]
> >> * sysdeps/sh/sh4/fpu/fgetexcptflg.c: New file.
> [snip]
> > That three-line comment makes me think this is a copy of the MIPS sysdeps
> > file; but yes, the implementation looks good to me.
>
> Thanks for your comment! I'll commit it with adding bugzilla
> line to the ChangeLog entry.
Remember when checking in a patch that fixes a bug that you also need to
add the bug number to the list of fixed bugs in NEWS, and to close the bug
as FIXED in Bugzilla.
--
Joseph S. Myers
joseph@codesourcery.com
More information about the Libc-alpha
mailing list