[PATCH 4/5][v2][BZ #15022] Extra dlopen/getpagesize static executable tests

Roland McGrath roland@hack.frob.com
Thu Jun 20 10:48:00 GMT 2013


>  So here are the extra dlopen/getpagesize tests.  They run successfully 
> for the mips-linux target.  As with the other dlopen tests I have added 
> extra commentary per your request.  Please let me know if you think this 
> change should refer to BZ #15022.  OK to apply?

If the test fails before the 15022 fix and passes after it, then it makes
sense to use the marker.

> +  /* Try to map a module into the global scope.  */
> +  handle = dlopen ("modstatic5.so", RTLD_LAZY | RTLD_GLOBAL);

I don't understand why this is using RTLD_GLOBAL.
That does not seem to be material to this test.

> +/* GLRO (dl_pagesize) initialization DSO tests with a static executable.

(Incidentally, we write GLRO(dl_pagesize) with no space.  It's a special
case.)  This line and the large comment below are the same for the two
cases.  tststatic5 already tests that.  So this must be testing different
things that need to be tested, or else there is no point in the second test.
Its comments should say what exactly it is testing.


Thanks,
Roland



More information about the Libc-alpha mailing list