[PATCH 2/2 v5] [BZ #10283] localedef: align fixed maps to SHMLBA
Roland McGrath
roland@hack.frob.com
Wed Jun 19 23:31:00 GMT 2013
You're not going to convince me that SHMLBA counts as "generic".
The code should be written to make MAP_FIXED_ALIGNMENT optional
and not do any extra alignment if it's not defined in libc-mmap.h.
The generic libc-mmap.h should be empty (just comments).
sysdeps/unix/sysv/linux/libc-mmap.h can use SHMLBA.
It may be worthwhile to define a proper public API for this (probably a GNU
extension sysconf code makes sense), document that and implement it
appropriately. The sysdeps/unix/sysv/linux implementation of that could
just use the existing SHMLBA. Then localedef would be changed to use that
API. But that's for the future.
Thanks,
Roland
More information about the Libc-alpha
mailing list