[PATCH 2/2] Add environment variable tuning for elision parameters.

[Torvald Riegel]

On Mon, 2013-06-17 at 19:58 +0200, Andi Kleen wrote:
> > > +  if (strncmp (s, "elision", 7) == 0 && (s[7] == 0 || s[7] == ':'))
> > > +    {
> > > +      __pthread_force_elision = __elision_available;
> > > +      if (s[7] == ':')
> > > +        elision_aconf_setup (s + 8);
> > > +    }
> > > +  else if (strncmp (s, "none", 4) == 0 && s[4] == 0)
> > 
> > This should be "no_elision" or something like that.  A setting like
> > "GLIBC_PTHREAD_MUTEX=none" is confusing: no what? no mutexes?
> 
> I can add an alias, but I personally prefer none.

I don't think an alias is what we want.  Instead, we want the external
interface to be clear, and I can't see how "MUTEX=none" is clear: None
of what?  What if we add other tunables for mutexes, to which "none"
could apply as well?  Is there a reason to prefer "none" over something
more descriptive (eg, "no_elision") beyond your personal preference?