PowerPC: Reserve TCB space for EBB framework

Ryan S. Arnold ryan.arnold@gmail.com
Fri Jun 14 21:12:00 GMT 2013


On Mon, Jun 3, 2013 at 10:42 PM, Adhemerval Zanella
<azanella@linux.vnet.ibm.com> wrote:
> On 06/04/2013 07:01 PM, Ryan S. Arnold wrote:
>> On Tue, Jun 4, 2013 at 4:14 PM, Adhemerval Zanella
>> <azanella@linux.vnet.ibm.com> wrote:
>>> diff --git a/nptl/sysdeps/powerpc/tls.h b/nptl/sysdeps/powerpc/tls.h
>>> index 46dac9e..56198fa 100644
>>> --- a/nptl/sysdeps/powerpc/tls.h
>>> +++ b/nptl/sysdeps/powerpc/tls.h
>>> @@ -64,6 +64,10 @@ typedef struct
>>>    uintptr_t pointer_guard;
>>>    uintptr_t stack_guard;
>>>    dtv_t *dtv;
>>> +  uintptr_t thread_handler;
>> This is a bit non-descriptive.  I'd prefer something like ebb_handler,
>> which describes the intended usage.
>>
>>> +  uintptr_t context_pointer;
>> Likewise ebb_context_pointer.
>>
>>> +  uintptr_t reserved1;
>>> +  uintptr_t reserved2;
>> Should these be marked ebb_ as well?  ebb_reserved1 and ebb_reserved2?
>
> I'll change it, but since their usage is only internal I was really
> worried about naming. We can change it later with EBB functional patches.

I'm fine with the patch.

Ryan



More information about the Libc-alpha mailing list