[PATCH] tdestroy() should allow passing 'NULL' for 'freefct' callback
Ivo Raisr
ivosh@ivosh.net
Wed Jun 12 11:36:00 GMT 2013
2013/6/11 Ondřej Bílka <neleai@seznam.cz>:
>
> From functional part this patch is mostly OK.
>
> I realized that there is simpler way to do this. You could test in tdestroy
> if freefct is null and set it to freenop.
I am sorry but I don't get your point here?
Your description matches changes done by this patch so I am confused by
your statement...
Never mind.
>
> There are several style issues, see:
> http://sourceware.org/glibc/wiki/Style_and_Conventions
> and post v2.
I found just one style issue with opening parenthesis and its indentation.
If there are some more style issues, please list them explicitly.
New patch (v2) is attached.
Ivosh
-------------- next part --------------
A non-text attachment was scrubbed...
Name: glibc-tdestroy-freefct-NULL-v2.patch
Type: application/octet-stream
Size: 1910 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/libc-alpha/attachments/20130612/b33361df/attachment.obj>
More information about the Libc-alpha
mailing list