[PATCH] Fix readdir_r with long file names

Florian Weimer fweimer@redhat.com
Fri Jun 7 07:56:00 GMT 2013


On 06/07/2013 03:30 AM, Rich Felker wrote:
> On Thu, Jun 06, 2013 at 03:53:16PM -0400, KOSAKI Motohiro wrote:
>> I mean, portable applications should use readdir_r correctly and Linux specific
>> one should use readdir instead.
>>
>> Side note: the above man page is not a theoretical issue. At least, Solaris
>> requires it.
>>
>> Am I missing something?
>
> Yes, the fact that the Austin Group is planning to require readdir to
> be thread-safe and to mark readdir_r obsolescent.

This is good news.

 > So effort put into
> making readdir_r more usable, or worse yet, adding a readdir4, is a
> waste of effort. Just make sure readdir_r is _safe_ against buffer
> overflows from buggy FUSE modules, and advise application developers
> to use readdir, not readdir_r.

Does this mean that you agree with the basic approach of the patch?

-- 
Florian Weimer / Red Hat Product Security Team



More information about the Libc-alpha mailing list