[PATCH 2/6 v2] Add fmemopen compatibility version.

[Joseph S. Myers]

On Wed, 5 Jun 2013, Ondrej Bilka wrote:

> > You may also need a versioned_symbol call to give the new fmemopen the 
> > right version; I'm not sure if that's required or if listing the new 
> > version in the Versions file will be sufficient.
> > 
> How is this done?

There are plenty of existing uses of versioned_symbol available as 
examples.

> Here is v2.
> 
> 	* libio/Makefile (routines): Add oldfmemopen.
> 	* libio/Versions (libc): Add compatibility symbol.
> 	* libio/oldfmemopen.c: New file.

This patch is either incorrect or incomplete.  If it works, it can't have 
passed testing, because all the ABI test baselines should be updated by a 
patch adding new symbol versions and this patch does not update them.  If 
it passed ABI testing, then it is broken and fails to add the new symbol 
version.

You need in such a case to make sure manually that both versions are 
exported, the old one as a compat symbol and the new one not as a compat 
symbol, with each pointing to the correct function implementation, in 
addition to the usual validation with the testsuite.

-- 
Joseph S. Myers
joseph@codesourcery.com