Cleanup #if 0

[Carlos O'Donell]

On 07/01/2013 04:31 PM, Ondrej Bilka wrote:
> On Mon, Jul 01, 2013 at 12:47:45PM -0700, H.J. Lu wrote:
>> On Mon, Jul 1, 2013 at 12:31 PM, H.J. Lu <hjl.tools@gmail.com> wrote:
>>> On Mon, Jul 1, 2013 at 12:27 PM, Liubov Dmitrieva
>>> <liubov.dmitrieva@gmail.com> wrote:
>>>> It is disabled for both. Where do you see it doesn't?
>>>>
>>>
>>> From:
>>>
>>> http://sourceware.org/git/?p=glibc.git;a=blob_plain;f=sysdeps/i386/i686/multiarch/strcasecmp.S;hb=HEAD
>>>
>>> I see __strcasecmp_sse4_2 is used when SHARED is define.
>>>
>>
>> I see what is going on.  This commit:
>>
>> http://sourceware.org/git/?p=glibc.git;a=commitdiff;h=6abf346582ba678f4850a88b4a5950593841df1d
>>
>> missed the "#if 0" removal for libc.a in strncase.S and
>> strcasecmp.S.  "#if 0" should be removed when SHARED
>> is defined.
>>
> As this caused problems it would be good idea to globaly remove code surrounded by 
> #if 0
> It is easy to automate, question is how many parts can be used and what are bitrotten.
> 
> Perhaps I can touch only these that are older than a year.
> 
> Comments?
> 

They should be reviewed manually and removed one by one.

We need to know why the code is there and why it's #if 0'd out.

Cheers,
Carlos.