[PATCH] Add ARM relocation constants to elf/elf.h

[Joseph S. Myers]

On Wed, 23 Jan 2013, Petr Machata wrote:

> Roland McGrath <roland@hack.frob.com> writes:
> 
> > We strongly prefer to have a short comment on every reloc type #define.
> 
> I don't think I have enough expertise to concisely explain what every
> relocation does.  I can at least put in e.g. what instructions each
> static relocation applies to, and add snippets from the standard where
> available.  Joseph, what is your preference?  FWIW, few relocation
> values in ARM block have any comments at all.

I'm not clear there is a great deal of use in having all these relocations 
(that are irrelevant to ld.so) in elf.h; what are the expected users, 
given that binutils has its own relocation definitions?  (Cf. how AArch64 
only lists a limited subset of relocations in elf.h, not all the static 
relocations that ld.so doesn't use.)  But if they are added, I think 
including comments is appropriate.

(If there are new dynamic relocations, of course they need implementing 
for the dynamic linker as well as adding to elf.h, although elf.h can go 
first in such cases.)

-- 
Joseph S. Myers
joseph@codesourcery.com