Adapt installed powerpc headers better for soft-float / no-FPRs

Roland McGrath roland@hack.frob.com
Tue Jan 15 00:08:00 GMT 2013


> +#if !defined _SOFT_FLOAT && !defined __NO_FPRS__
>  /* The powerpc has a combined multiply/add instruction.  */
> -# define FP_FAST_FMA 1
> -# define FP_FAST_FMAF 1
> +#  define FP_FAST_FMA 1
> +#  define FP_FAST_FMAF 1
> +#endif

You added the second space to the define lines but omitted the necessary
single space on the if/endif.

> -#if defined __GNUC__ && !defined _SOFT_FLOAT && !defined __NO_MATH_INLINES
> +#if defined __GNUC__ && !defined _SOFT_FLOAT && !defined __NO_FPRS__ \
> +  && !defined __NO_MATH_INLINES

Please use parens in such cases so the indentation is coherent.


Thanks,
Roland



More information about the Libc-alpha mailing list