[PATCH 03/10] Add external interface changes: new lock types for pthread_mutex_t

[Carlos O'Donell]

On 01/13/2013 04:29 PM, Andi Kleen wrote:
> On Sun, Jan 13, 2013 at 04:20:26PM -0500, Carlos O'Donell wrote:
>>  
>>> With the trylock change people are asking for a third flag
>>> would be also needed.
>>
>> Why can't you collapse that to 2 bits? Reserve 30/29 for elision
>> uses?
> 
> Environment variable can enable/disable.
> To give the program full control it needs two bits per lock: force enable/disable
> so that it can override any environment state.

Thanks, I'd missed that you wanted to also force elision for all
locks in a process.

Would it be possible for you to start setting up branches on
sourceware corresponding to v1, v2, v3 ... etc versions of your
patch so I can look at the complete patch set easily?
 
> With the trylock change we would also need to distingush between
> auto enabled elision and program force enabled elision (so that force
> enables can still do trylock elision, but auto enabled would not). 
> This would need a third bit.

Agreed.

Cheers,
Carlos.