[PATCH] Remove `attr != NULL' assert in allocate_stack.

Carlos O'Donell codonell@redhat.com
Sat Jan 12 01:54:00 GMT 2013


On 01/10/2013 11:37 PM, Carlos O'Donell wrote:
> The allocate_stack function is an internal function that is used
> only by glibc and only from pthread_create. We don't need an
> assert on a value we control and we know to be non-NULL. Just
> like we don't assert that pdp is non-NULL, or any other number
> of input arguments we control entirely.
> 
> However, the function does need documenting that neither of
> the input arguments should be NULL.
> 
> No regressions on x86_64.
> 
> OK to commit?
> 
> 2012-01-10  Carlos O'Donell  <codonell@redhat.com>
> 
> 	* allocatestack.c (allocate_stack): Remove assert for attr.

Committed.

Cheers,
Carlos.



More information about the Libc-alpha mailing list