[PATCH][PPC] Remove unnecessary local variable mptwo

Richard Henderson rth@twiddle.net
Thu Jan 10 17:14:00 GMT 2013


On 01/10/2013 07:50 AM, Carlos O'Donell wrote:
> On 01/09/2013 06:40 AM, Siddhesh Poyarekar wrote:
>> Hi,
>>
>> Attached patch removes the local variable mptwo from the __inv
>> function so that it uses the global static definition instead.  No
>> regressions resulting from this patch.  OK to commit?
>>
>> Siddhesh
>>
>> 	* sysdeps/powerpc/powerpc32/power4/fpu/mpa.c (__inv): Remove
>> 	local variable MPTWO.
>> 	* sysdeps/powerpc/powerpc64/power4/fpu/mpa.c (__inv): Likewise.
>
> How does this impact the generated code?
>
> How does that impact mpatan's performance?

It's an initialized non-static local variable that has to be constructed 
on every invocation of __inv.  Replacing that with a  reference to a 
hidden global variable has got to be an improvement.


r~



More information about the Libc-alpha mailing list