[PATCH 01/15] Support multiarch under OS directory

[Andreas Jaeger]

On 01/03/2013 05:03 PM, H.J. Lu wrote:
> On Thu, Jan 3, 2013 at 7:20 AM, Andreas Jaeger <aj@suse.com> wrote:
>> On 12/23/2012 04:02 AM, Andi Kleen wrote:
>>>
>>> From: "H.J. Lu" <hjl.tools@gmail.com>
>>
>>
>> Let's push this patch interdependent of the others in - but it needs a
>> proper reasoning what it will do and why it's needed.
>>
>> Please explain what you want to achieve here,
>
> configure was supposed to support multiarch directory
> under sysdeps/unix/sysv/linux/x86_64, as m0sub and msub
> used in directory scan:
>
> try="${d}sysdeps$m0$m0sub$b$v$o$m$msub$a"
>
> But we never set m0sub and msub.  As the result, we never
> check multiarch directory under OS directory.  My patch adds
> the missing m0sub and msub. Ignoring white spaces, my patch is:
>
> diff --git a/configure b/configure
> index 8799b7d..bf73d05 100755
> --- a/configure
> +++ b/configure
> @@ -4347,11 +4347,13 @@ sysnames_add_ons=
>   sysnames=
>   for b in $base ''; do
>     for m0 in $mach ''; do
> +    for m0sub in $mach ''; do
>         for v in /$vendor ''; do
>     test "$v" = / && continue
>     for o in /$ostry ''; do
>       test "$o" = / && continue
>       for m in $multi_arch_d $mach ''; do
> +      for msub in $multi_arch_d $mach ''; do
>           for d in $add_ons_pfx ''; do
>        for a in $add_ons_sfx ''; do
>          if test -n "$m0$m0sub$b$v$o$m$msub"; then
> @@ -4384,6 +4386,8 @@ for b in $base ''; do
>     done
>         done
>       done
> +  done
> +done
>
> It is a correctness issue.

In that case, the code looks fine to me but I'd like to see Roland 
review this since he was involved with much of this cleanup,

thanks,
Andreas


-- 
  Andreas Jaeger aj@{suse.com,opensuse.org} Twitter/Identica: jaegerandi
   SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
    GF: Jeff Hawn,Jennifer Guild,Felix Imendörffer,HRB16746 (AG Nürnberg)
     GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126