[PATCH] Mark inputs being ZERO as unlikely __mul in powerpc

Carlos O'Donell carlos@redhat.com
Wed Feb 20 16:29:00 GMT 2013


On 02/20/2013 09:18 AM, Siddhesh Poyarekar wrote:
> On Wed, Feb 20, 2013 at 07:19:21PM +0530, Siddhesh Poyarekar wrote:
>> Hi,
>>
>> The patch below marks the case of X or Y being ZERO as unlikely on
>> powerpc.  This makes no difference to the generated code.  The only
>> purpose is to sync up the code with the default code.  OK to commit?
>>
> 
> Sorry, this does not result in identical code.  It improves
> performance by a tiny bit (0.3%), similar to that on x86.  OK to
> commit?

In light of the performance improvement it seems like this should just
be committed.

If you want you can kick-off a question regarding concensus:
"If performance is not degraded, can patches that synchronize
 machine copies of code with generic copies of code be committed
 without review?"

Cheers,
Carlos.



More information about the Libc-alpha mailing list