[PATCH] Refactor common code from nscd's two main poll loops.

Andreas Jaeger aj@suse.com
Fri Feb 8 18:51:00 GMT 2013


On 02/08/2013 06:54 PM, Carlos O'Donell wrote:
> On 02/08/2013 03:11 AM, Andreas Jaeger wrote:
>>> 2013-02-07  Carlos O'Donell  <carlos@redhat.com>
>>>
>>>      * nscd/connection.c (register_traced_file): Comment function.
>>>      [HAVE_INOTIFY] (union __inev): Define.
>>>      [HAVE_INOTIFY] (inotify_check_files): New function.
>>>      [HAVE_INOTIFY] (clear_db_cache): Likewise.
>>>      [HAVE_INOTIFY] (main_loop_poll): Call inotify_check_files and
>>>      clear_db_cache.
>>>      [HAVE_INOTIFY] (main_loop_epoll): Likewise.
>>>
>
> Fixed and committed.
>
>>> +static inline void
>>> +inotify_check_files(bool *to_clear, union __inev *inev)

Sorry, I just see the inline above (reviewed it before seeing other 
emails). After Roland's cleanup, I think that shouldn't be there anymore 
- so could you commit the obvious followup and remove the inlines again, 
please?

thanks,
Andreas
-- 
  Andreas Jaeger aj@{suse.com,opensuse.org} Twitter/Identica: jaegerandi
   SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
    GF: Jeff Hawn,Jennifer Guild,Felix Imendörffer,HRB16746 (AG Nürnberg)
     GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126



More information about the Libc-alpha mailing list