[PATCH] handle EPROTOTYPE for socket invocations with SOCK_* flags
Roland McGrath
roland@hack.frob.com
Fri Feb 8 00:22:00 GMT 2013
> OK. Before I send a new, possibly rejected, version of the patch, are
> there further comments on the actual function itself (naming, style,
> content, etc) and its use?
The name is poor. It doesn't tell me anything about what it's actually for.
And there should be a comment on the definition describing its purpose.
I don't see any other issues off hand, but watch out for lines >79 columns.
Thanks,
Roland
More information about the Libc-alpha
mailing list