[PATCH] Call memcpy in generic mempcpy

Roland McGrath roland@hack.frob.com
Wed Feb 6 23:19:00 GMT 2013


> On 02/06/13 12:53, Ond$,1 y(Bej B,Am(Blka wrote:
> >    unsigned long int dstp = (long int) dstpp;
> ...
> > +  memcpy (dstpp, srcpp, len);
> > +  return (void *) (dstp + len);
> 
> There's no need to use an integer type, or
> to do any casts.  Something like this, perhaps?
> 
>   char *dstp = dstpp;
>   memcpy (destpp, srcpp, len);
>   return dstp + len;

It's GNU code and can assume GNU C extensions.
So there isn't even a need for a cast.
And, it's more efficient to use the return value.



More information about the Libc-alpha mailing list