[PATCH][v2] Add dynamic linker support for $EXEC_ORIGIN.

Mike Frysinger vapier@gentoo.org
Mon Dec 23 09:03:00 GMT 2013


On Thursday 12 December 2013 17:13:39 Brooks Moses wrote:
> --- a/elf/dl-dst.h
> +++ b/elf/dl-dst.h
>
> +	char *exec_origin = GLRO(dl_exec_origin_path);			      \

shouldn't that be const ?

i've always wondered why the "space before (" rule doesn't apply to 
GLRO/INTUSE macros.

> --- a/elf/rtld.c
> +++ b/elf/rtld.c
> 
> +static void set_exec_origin_path(const char *exe_path);

space before the (

otherwise, looks OK, but probably should get sign off from someone more 
familiar with the ldso code
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://sourceware.org/pipermail/libc-alpha/attachments/20131223/311e264d/attachment.sig>


More information about the Libc-alpha mailing list