[PATCH 1/4] Add _dl_{mask,unmask}_all_signals

Paul Pluzhnikov ppluzhnikov@google.com
Fri Dec 20 19:28:00 GMT 2013


On 12/20/13, 2:53 AM, Thomas Schwinge wrote:

> This got pushed as commit 69a17d9d245dc3551792e95e1823cc2d877592f3; the
> ChangeLog shows Andrew as the author, but the Git author entry shows
> Paul?

Is the standard procedure here to supply '--author=Andrew Hunter 
<ahh@google.com>' to git-commit?


> In ldsodefs.h, the unmasking declaration is named _dl_unmask_signals
> (matching the implementation in the Linux dl-sysdep.c), and in the
> dl-sysdep.h files it's named _dl_unmask_all_signals.

Sorry about the mess. The patch bit-rotted before even getting in, and 
we don't have an easy way to test Hurd builds.

> I suggest to fix this up as follows, or should this be done differently?
> Testing for Hurd is running; could you please test the Linux case?

Looks good to me. Testing on Linux/x86_64 ...
Builds fine, no new warnings, no regressions.

Thanks for the fix!



More information about the Libc-alpha mailing list