[PATCH 2/4] Add a signal-safe malloc replacement
Joseph S. Myers
joseph@codesourcery.com
Thu Dec 19 18:11:00 GMT 2013
On Thu, 19 Dec 2013, Ondrej Bilka wrote:
> One possible approach would be have a warning subsection in Makefile like:
>
> # gcc gets false positive on line 42
> CFLAGS-foo.c += -Wno-error=bar
If we do this, I think we should actually quote something of the warning
rather than just giving a line number that may be meaningless after source
code changes.
There are quite a lot of -Wno- options in various Makefiles in the source
tree. It would be good to review them and see if some are in fact no
longer needed, or if the relevant code can be fixed to avoid them.
Generally any such workarounds for warnings need occasional review to
avoid them staying around longer than necessary and so meaning warnings
pointing out real problems get missed.
I'd suggest -Werror is only applied to installed code not testcases, if
possible, since testcases can have good reason to do dubious things that
will generate warnings.
--
Joseph S. Myers
joseph@codesourcery.com
More information about the Libc-alpha
mailing list