[PATCH v2.1 1/2][BZ #16274] Fix shm_open.

Ondřej Bílka neleai@seznam.cz
Tue Dec 3 15:28:00 GMT 2013


On Tue, Dec 03, 2013 at 10:09:15AM -0500, Carlos O'Donell wrote:
> On 12/03/2013 06:20 AM, Ondřej Bílka wrote:
> >> Shouldn't this be s/0/-1/g? It's a real failure?
> > 
> > It is failure as we passed EXIT_FAILURE to status, arguments to error are:
> > 
> >  error (int status, int errnum, const char *format, ...)
> > 
> 
> Sorry, I forgot the order of the arguments to this function.
> 
> Let me rephrase my question more precisely.
> 
> Should we instead use:
> 
> error (EXIT_FAILURE, errno, "failed to create shared memory object: shm_open");
> 
> Such that we print:
> 
> "failed to create shared memory object: shm_open: `strerror(errno)'"
> 
Possible but as existing checks pass 0 we should also convert them as
separate patch.



More information about the Libc-alpha mailing list