[PATCH] dlfcn: do not mark dlopen/dlclose as leaf functions
Roland McGrath
roland@hack.frob.com
Mon Aug 26 22:25:00 GMT 2013
> Since the dlopen funcs might invoke a constructor that is in the same
> compilation unit as the caller, we cannot mark them as leaf funcs.
>
> Similarly, dlclose might invoke a destructor that is in the same
> compilation unit as the caller.
This description doesn't track. You meant to say "indirectly invoke".
The comments in the test case are clear enough, but this introduction
was misleading enough that I thought you might be wrong about something.
The comments at the top of the test sources are not in the canonical style.
Nowadays I think we are doing copyright notices on new test cases too.
Every new test case should use test-skeleton.c unless there's a big reason
that it cannot.
And, needs a BZ# filed as was already mentioned.
Thanks,
Roland
More information about the Libc-alpha
mailing list