[PATCH] Missing string termination in elf-setup-vdso.h?

[Andreas Arnez]

While trying to understand what information is stored for VDSOs in the
link map, I stumbled upon what looks like a missing string termination
bug.  It seems that this code is usually not reached; thus I'm not sure
which systems are affected by this (potential) bug.


2013-08-19  Andreas Arnez  <arnez@linux.vnet.ibm.com>

	* elf/setup-vdso.h (setup_vdso): Fix missing string termination.


diff --git a/elf/setup-vdso.h b/elf/setup-vdso.h
index a98dfec..056d885 100644
--- a/elf/setup-vdso.h
+++ b/elf/setup-vdso.h
@@ -89,7 +89,7 @@ setup_vdso (struct link_map *main_map __attribute__ ((unused)),
 	     addresses in the vsyscall DSO pages in writev() calls.  */
 	  const char *dsoname = ((char *) D_PTR (l, l_info[DT_STRTAB])
 				 + l->l_info[DT_SONAME]->d_un.d_val);
-	  size_t len = strlen (dsoname);
+	  size_t len = strlen (dsoname) + 1;
 	  char *copy = malloc (len);
 	  if (copy == NULL)
 	    _dl_fatal_printf ("out of memory\n");