[PATCH] Move bench target into benchtests

Siddhesh Poyarekar siddhesh@redhat.com
Tue Apr 9 15:39:00 GMT 2013


On Tue, Apr 09, 2013 at 09:38:27AM -0400, Carlos O'Donell wrote:
> > +bench: $(binaries-bench)
> > +	for run in $^; do \
> > +	  echo "Running $${run}"; \
> > +	  eval $(run-bench) >>  $(objpfx)bench.out-tmp; \
> 
> Do you need `eval' here? Schwab caught this in my implementation also,
> and I didn't need it because all the variables were resolved by the time
> the command is evaluated.
> 

Tulio had added it IIRC to get it to work on powerpc.  I'll check if
it is in fact needed and if not, I'll just remove it.

Siddhesh



More information about the Libc-alpha mailing list