[PATCH v2] Rebuild benchmark sources when Makefile is updated

Siddhesh Poyarekar siddhesh@redhat.com
Tue Apr 9 08:39:00 GMT 2013


On Mon, Apr 08, 2013 at 03:09:56PM -0700, Roland McGrath wrote:
> I may be missing some context because I didn't find time to review your
> original bench/ additions and they went in without my involvement.
> 
> Why is any of this stuff in Rules at all?  It appears to be relevant only
> to bench/Makefile and so it should be there.  Is there some intent to
> support the 'bench' variable in other subdir makefiles?

and here's this patch updated to apply to benchtests/Rules instead.

Siddhesh

	* benchtests/Rules ($(objpfx)bench-%.c): Depend on Makefile.

diff --git a/benchtests/Rules b/benchtests/Rules
index 4715084..9906bb0 100644
--- a/benchtests/Rules
+++ b/benchtests/Rules
@@ -40,7 +40,7 @@ $(binaries-bench): %: %.o \
   $(addprefix $(csu-objpfx),start.o) $(+preinit) $(+postinit)
 	$(+link)
 
-$(objpfx)bench-%.c: %-inputs bench-skeleton.c
+$(objpfx)bench-%.c: %-inputs bench-skeleton.c Makefile
 	{ if [ -n "$($*-INCLUDE)" ]; then \
 	  cat $($*-INCLUDE); \
 	fi; \



More information about the Libc-alpha mailing list