[PATCH][BZ #15346] Allow leading and trailing spaces in getdate

[Roland McGrath]

> On Mon, Apr 08, 2013 at 01:12:56PM -0700, Roland McGrath wrote:
> > > +  /* Skip leading spaces.  */
> > 
> > s/spaces/whitespace/
> > 
> > > +  while (string[i] && isspace (string[i]))
> > > +    i++;
> > 
> > Avoid Boolean coercion: string[i] != '\0'.
> > But since you've already done strlen, why not i < inlen?
> 
> I don't think it matters here, but in general the idiom of testing for
> a zero byte is superior to comparing against the length, because it
> involves one fewer variables (and thus less register pressure) in the
> loop.

Fair enough.  In this case you're going to do the load regardless, so it's
never saving a load.  

But in that case it seems optimal to call strlen on &string[i] after this
loop (or make the loop increment string itself).