Pushing a git note fails.

[Jim Meyering]

Carlos O'Donell wrote:

> Team,
>
> I did a commit, but forgot to update the ChangeLog.
...
>
> This note is a local "commit" namespace note and I need to
> push it up to the server like this:
> ~~~
> [carlos@koi glibc]$ git push origin refs/notes/*
> Counting objects: 3, done.
> Delta compression using up to 4 threads.
> Compressing objects: 100% (3/3), done.
> Writing objects: 100% (3/3), 331 bytes, done.
> Total 3 (delta 0), reused 0 (delta 0)
> remote: *** Update hook: unknown type of update to ref refs/notes/commits of type commit
> remote: error: hook declined to update refs/notes/commits
> To ssh://carlos@sourceware.org/git/glibc.git
>  ! [remote rejected] refs/notes/commits -> refs/notes/commits (hook declined)
> error: failed to push some refs to 'ssh://carlos@sourceware.org/git/glibc.git'
> ~~~
>
> But it fails.
>
> It looks like our commit hooks don't allow notes.

What policy would you like with notes?

I've just made this untested change to the git-vc'd
update script that sets such policy.  If it's what you'd
like, I'll commit as is.  Happy to adjust, too.


diff --git a/update b/update
index ed76bd2..f5385a0 100755
--- a/update
+++ b/update
@@ -171,6 +171,9 @@ case "$refname","$newrev_type" in
 			exit 1
 		fi
 		;;
+	refs/notes/*,*)
+		# Notes: no restrictions.
+		;;
 	*)
 		# Anything else (is there anything else?)
 		echo "*** Update hook: unknown type of update to ref $refname of type $newrev_type" >&2