[PATCH] Get rid of ASM_SIZE_DIRECTIVE (take 2)

Mike Frysinger vapier@gentoo.org
Wed Sep 19 18:19:00 GMT 2012


On Tuesday 18 September 2012 14:57:17 Carlos O'Donell wrote:
> On 9/18/2012 1:06 PM, Roland McGrath wrote:
> > That looks fine to me, though I am having second thoughts about the exact
> > choice of name.  SYMBOL_SIZE doesn't really communicate that it computes
> > based on ., i.e. that the placement of the macro relative to assembly
> > code following the symbol is crucial.  Good names are not coming to mind
> > just now.
> 
> Imply that it's computed: SYMBOL_CALC_SIZE?
> 
> Imply that it's positional: SYMBOL_HERE_SIZE?

if we aren't terribly set on names, i'd say let's just use the same macros 
that the kernel already does since other projects have picked up those styles.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://sourceware.org/pipermail/libc-alpha/attachments/20120919/c1648cc8/attachment.sig>


More information about the Libc-alpha mailing list